Feature: Governance Updatable Governance Params

[apbendi]

🧐 Motivation

Feature parity with Compound Governor Bravo.

📝 Details

In Compound's Governor Bravo, it's possible for Governance itself to update the following governance parameters:

• votingDelay
• votingPeriod
• proposalThreshold

In the OZ Governance system, these parameters are never implemented concretely, but instead exist as virtual parameters. (Unless, of course, I'm missing something!).

• votingDelay
• votingPeriod
• proposalThreshold

The expectation is, presumably, that each project will implement these parameters on their own concrete instance and set them to whichever values they prefer. It would also be possible for said implementer to also create setters for these parameters with appropriate logic around who can set them.

In order to offer out-of-the box feature parity with Bravo, we propose the following course of action:

Implement a concrete Governor instance that:

• Takes values for the three governance parameters as arguments in its constructor
• Has setters for each param bounded by onlyGovernance
• Does basic validation of the parameters in both the constructor and setter methods

We are happy to take a first pass at this feature and open a PR if it is something the OZ team would be willing to merge if implemented. Thanks for your consideration!

[Amxx]

Does basic validation of the parameters in both the constructor and setter methods

What checks do you imagine? The only I can think of is votingPeriod > 0

[apbendi]

@Amxx Wow you're fast!

Bravo has immutable Min/Max thresholds: https://github.com/Arr00-Blurr/compound-protocol/blob/master/contracts/Governance/GovernorBravoDelegate.sol#L297

I think some kind of Max is a must have, because setting any of these too high could effectively brick your governance.

[Amxx]

#2866