Skip to content

Make ECDSA.recover revert on failure #1978

Closed
@nventuro

Description

recover returning the zero address instead of reverting, while consistent with the behavior of ecrecover, is wildly inconsistent with the rest of the library. We should follow the principle of least surprise and bring it in line with other functions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    breaking changeChanges that break backwards compatibility of the public API.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions