Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ERC165 testing #1203

Closed
nventuro opened this issue Aug 13, 2018 · 3 comments
Closed

Improve ERC165 testing #1203

nventuro opened this issue Aug 13, 2018 · 3 comments
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.

Comments

@nventuro
Copy link
Contributor

As noted here, we should improve our shouldSupportInterfaces functions so that they not only test the interface has been registered, but also that it actually exists in the API, preventing mis-registration and errors like the one made in #1193.
@nventuro nventuro added good first issue Low hanging fruit for new contributors to get involved! kind:improvement tests Test suite and helpers. labels Aug 13, 2018
@nventuro nventuro added this to the v2.1 milestone Aug 13, 2018
@Aniket-Engg
Copy link
Contributor

I think this can be tested by checking that a corresponding .json file exists in build folder.

@nikeshnazareth
Copy link
Contributor

can I take this one?

@nventuro
Copy link
Contributor Author

nventuro commented Mar 6, 2019

@nikeshnazareth go ahead! This one has been in the backlog for a long time now, but it'd be great if we got it done :)

@nikeshnazareth nikeshnazareth mentioned this issue Mar 7, 2019
Merged
nventuro pushed a commit that referenced this issue Mar 7, 2019
@nikeshnazareth @nventuro
Improve erc165 testing #1203 (#1666)
4dd8575 
* Rename variable from thing to contractUnderTest

* Compute function signatures in ERC165 interfaces

The ERC165 tests currently precompute some known interface ids.
This commit extracts the interfaces into a separate object and
precomputes the individual function signatures.

This will be useful to identify contracts that support an interface
but do not implement all of the corresponding functions.

* Add tests for ERC165 interface implementations

The ERC165 tests confirm that contracts claim to support
particular interfaces ( using the supportsInterface method )

This commit extends those tests to confirm that the corresponding
functions are included in the contract ABI.

It also rewords the existing test names in order to group the
implementation tests with the corresponding interface tests.

* Remove obsolete ERC721Exists interface constant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Low hanging fruit for new contributors to get involved! tests Test suite and helpers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nventuro @nikeshnazareth @Aniket-Engg