Cross-chain standardisation: ERC-7786 interfaces, helpers and Axelar adapter #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Francisco Giordano <fg@frang.io>
Co-authored-by: Francisco Giordano <fg@frang.io>
#22) * Updated ERC specs * executeMessage returns bytes4 * Add AxelarGatewayDuplex * remove npm contracts dependency in favor of the master submodule * slither remappings * clarify CAIP-10 format * document reverts * unused imports * unexpected attributes too short * document remoteGateway format * clarify AxelarGatewayDestination._execute * rewrite require(..., error); as if (...) revert error; * typography * custom errors * replace require with string with custom error * Apply audit review suggestions * Adjust checks.yml * Point gitmodules to master on OZ contracts * lint * Fix CI * Fix CI 2 * Fix slither * up * up * Disable locked-ether slither rule for duplex * Make prettier version consistent * Remove passive mode * Apply suggestions from code review Co-authored-by: Ernesto García <ernestognw@gmail.com> * Update contracts/crosschain/axelar/AxelarGatewayDuplex.sol --------- Co-authored-by: Ernesto García <ernestognw@gmail.com>
✅ Deploy Preview for community-contracts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Amxx
reviewed
Nov 29, 2024
| @@ -49,8 +52,9 @@ | |||
| "ethers": "^6.12.1", | |||
| "hardhat": "^2.22.3", | |||
| "hardhat-exposed": "^0.3.15", | |||
| "prettier": "^3.2.5", | |||
| "prettier": "^3.0.3", | |||
There was a problem hiding this comment.
If anyone is curious: @openzeppelin/contracts uses ^3.0.0.
If we use 3.2.5 here, the linter will find issues in lib/@openzeppelin-contract.
We should make configure the linter so that it does not check lib/*
There was a problem hiding this comment.
We either go back here or up in the master branch of the vanilla repository
There was a problem hiding this comment.
created an issue for that: #29
Amxx
approved these changes
Nov 29, 2024
Amxx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.