Skip to content

Commit

Permalink
Simplify remappings and use master for OpenZeppelin dependencies (#26)
Browse files Browse the repository at this point in the history
* Simplify remappings and use master for OpenZeppelin dependencies

* Adapt CI

* up

* up

* up

* up

* up

* up
  • Loading branch information
ernestognw authored Nov 28, 2024
1 parent 355cb82 commit 85bb62c
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 36 deletions.
3 changes: 3 additions & 0 deletions .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,6 @@ runs:
uses: foundry-rs/foundry-toolchain@v1
with:
version: nightly
- name: Install submodule dependencies
shell: bash
run: forge install
5 changes: 0 additions & 5 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Bring vanilla repository test utils as a submodule
run: forge install
- name: Run tests and generate gas report
run: npm run test

Expand All @@ -46,8 +44,6 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- name: Bring vanilla repository test utils as a submodule
run: forge install
- name: Run coverage
run: npm run coverage

Expand All @@ -68,7 +64,6 @@ jobs:
- uses: actions/checkout@v4
- name: Set up environment
uses: ./.github/actions/setup
- run: rm foundry.toml
- uses: crytic/slither-action@v0.4.0

codespell:
Expand Down
2 changes: 1 addition & 1 deletion foundry.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[profile.default]
solc_version = '0.8.26'
solc_version = '0.8.27'
evm_version = 'cancun'
src = 'contracts'
out = 'out'
Expand Down
2 changes: 1 addition & 1 deletion hardhat.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { argv } = require('yargs/yargs')()
.options({
compiler: {
type: 'string',
default: '0.8.26',
default: '0.8.27',
},
hardfork: {
type: 'string',
Expand Down
17 changes: 0 additions & 17 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@
"security",
"zeppelin"
],
"dependencies": {
"@openzeppelin/contracts": "^5.0.2",
"@openzeppelin/contracts-upgradeable": "^5.0.2"
},
"dependencies": {},
"devDependencies": {
"@nomicfoundation/hardhat-chai-matchers": "^2.0.6",
"@nomicfoundation/hardhat-ethers": "^3.0.5",
Expand Down
8 changes: 2 additions & 6 deletions remappings.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
@openzeppelin/contracts@v5/=node_modules/@openzeppelin/contracts/
@openzeppelin/contracts-upgradeable@v5/=node_modules/@openzeppelin/contracts-upgradeable/

@openzeppelin/contracts@master/=lib/@openzeppelin-contracts/contracts/
@openzeppelin/contracts-upgradeable@master/=lib/@openzeppelin-contracts-upgradeable/contracts/

@openzeppelin/contracts/=lib/@openzeppelin-contracts/contracts/
@openzeppelin/contracts-upgradeable/=lib/@openzeppelin-contracts-upgradeable/contracts/
@openzeppelin/community-contracts/=contracts/
3 changes: 1 addition & 2 deletions slither.config.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"detectors_to_run": "arbitrary-send-erc20,array-by-reference,incorrect-shift,name-reused,rtlo,suicidal,uninitialized-state,uninitialized-storage,arbitrary-send-erc20-permit,controlled-array-length,controlled-delegatecall,delegatecall-loop,msg-value-loop,reentrancy-eth,unchecked-transfer,weak-prng,domain-separator-collision,erc20-interface,erc721-interface,locked-ether,mapping-deletion,shadowing-abstract,tautology,write-after-write,boolean-cst,reentrancy-no-eth,reused-constructor,tx-origin,unchecked-lowlevel,unchecked-send,variable-scope,void-cst,events-access,events-maths,incorrect-unary,boolean-equal,cyclomatic-complexity,deprecated-standards,erc20-indexed,function-init-state,pragma,unused-state,reentrancy-unlimited-gas,constable-states,immutable-states,var-read-using-this",
"filter_paths": "contracts/mocks,contracts-exposed",
"compile_force_framework": "hardhat"
"filter_paths": "contracts/mocks,contracts-exposed"
}

0 comments on commit 85bb62c

Please sign in to comment.