Proving Period Library #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are conceptually different operations. Also, I think it is now clearer that we are only updating values in a period that hasn't started (even though that it is not enforced in the function)
This should always be true in practice but since we do use a zero prover to identify a vacant period, I think we should check it explicitly
Before this commit the finalizePastPeriod function confirmed there is a publication after period.end but it did not confirm that period.end was non-zero
Also ensure users can only initialize periods with a non-zero prover. This prevents finalizing the same period multiple times. In practice, there is no reason to do so, because the stake is already distributed, but it is better to prevent it explicitly for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is almost a pure refactor. The only functional changes are:
finalizePastPeriodto ensure the target period is closed.finalizePastPeriodnow zeroes out the prover and requires the period to have a non-zero prover. This means it can only be called once per period.The main changes are moving period-related functionality to a new library for better readability and encapsulation. It also moves the balance accounting and configuration parameters into their own abstract contracts for better encapsulation.