Skip to content

Removes start publication from checkpoint #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LeoPatOZ
Copy link
Collaborator

@LeoPatOZ LeoPatOZ commented Apr 25, 2025

As we have decided not to allow for parallel proving (i.e. proving publications not starting from the latest proven), we no longer should / need to accept 'start' checkpoint when proving a transition - it will always be the latest proven checkpoint.

Slightly more gas efficient

Im not sure if we need to check L238 in the prover manager

Copy link

github-actions bot commented Apr 25, 2025

Changes to gas cost

Generated at commit: c299f04050b2dd772c2670a832acd35d323afc18, compared to commit: 6d08743d2312340033442e3745582597c7041ff9

🧾 Summary (10% most significant diffs)

Contract Method Avg (+/-) %
CheckpointTracker proveTransition -860 ✅ -1.17%
ProverManager prove -766 ✅ -0.76%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
CheckpointTracker 809,718 (-100,114) proveTransition 72,814 (-860) -1.17% 72,814 (-860) -1.17% 72,814 (-860) -1.17% 72,814 (-860) -1.17% 1 (0)
ProverManager 2,850,936 (-3,494) prove 85,943 (-766) -0.88% 99,606 (-766) -0.76% 101,556 (-766) -0.75% 111,314 (-766) -0.68% 6 (0)

@LeoPatOZ LeoPatOZ requested a review from ggonzalez94 April 25, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant