Skip to content

Add onlyEntryPointOrSelf modifer to multisig #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

ernestognw
Copy link
Member

Add missing modifers to multisigs

@ernestognw ernestognw marked this pull request as ready for review May 19, 2025 03:17
@ernestognw ernestognw requested review from ericglau and CoveMB May 19, 2025 15:08
Copy link
Contributor

@CoveMB CoveMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific set of ok/fail tests that could be added?

@ernestognw
Copy link
Member Author

I think those are the snapshot tests, it's just difficult to get it at first when reviewing hundreds of combinations 😂

Copy link
Member

@ericglau ericglau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this should have a changeset since the previous account functionality was already released.

Copy link
Contributor

@CoveMB CoveMB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻

@ernestognw ernestognw enabled auto-merge (squash) May 21, 2025 15:25
@ernestognw ernestognw merged commit 76b3ca6 into master May 21, 2025
21 checks passed
@ernestognw ernestognw deleted the fix/add-modifiers-to-multisig branch May 21, 2025 15:33
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants