Escape encoding of special character to avoid crash of bto #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Eric Lau <ericglau@outlook.com>
|
🔥 Nice. Let's wait for the Remix part before proceeding with this PR, since otherwise the decoding would be incorrect. |
|
Got merged on Remix's side |
ericglau
approved these changes
May 21, 2025
shahnami
approved these changes
May 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a contract contained special characters opening it with remix would fail as
btoawould not support special characters.The following change will escape special characters before encoding.
This will ensure that the app does not crash in the presence of special characters.
A change has also been proposed on remix side to support decoding of the escaped special characters.
Behavior with only this merge request
Behavior after support on remix side
Fixes #545