-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add compatibility notice #861
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, Marto! Piggybacking off of Eric's review, I left a comment and a suggestion
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion. Otherwise, LGTM!
Co-authored-by: Andrew Fleming <fleming-andrew@protonmail.com>
Fixes #756.
Also added a few not previously discussed directives, like our rule regarding underscores. Open to discuss if needed.
PR Checklist
TestsAdded entry to CHANGELOG.mdTried the feature on a public network