Draft
Conversation
- Move integration tests from inline #[cfg(test)] modules to tests/ folder: - tests/common.rs - shared test utilities - tests/eth_namespace.rs - Ethereum RPC method tests - tests/custom_methods.rs - RobustProvider-specific method tests - tests/subscription.rs - WebSocket subscription tests - Keep internal unit tests in src/robust_provider/provider.rs (retry logic) - Export additional types needed by tests (DEFAULT_FINALIZATION_HEIGHT, SubscriptionError, RobustSubscriptionStream)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #7
The idea of the PR is to slowly introduce integration tests (i.e.e test that validate against real nodes).
This is more of a POC to see if we like this design.
One issue is that there is no standard way to mine blocks on this testnet so we are limited to fresh chains.
Questions:
Should we use shadow fork mode so we can get 'real' data i.e. real blocks / events
This would mean we could test more real life scenarios however we would have missed out on some edge case testing around genesis height testing.
Still missing: