Skip to content

Properly convert Geth errors related to non-existent blocks into BlockNotFound#13

Merged
0xNeshi merged 13 commits intomainfrom
handle-geth-block-query
Jan 15, 2026
Merged

Properly convert Geth errors related to non-existent blocks into BlockNotFound#13
0xNeshi merged 13 commits intomainfrom
handle-geth-block-query

Conversation

@0xNeshi
Copy link
Collaborator

@0xNeshi 0xNeshi commented Jan 15, 2026 •
edited
Loading

Towards #12

This is a quick-fix solution until #12 is investigated.

Removed block_id field from BlockNotFound for two reasons:

  • it's redundant - the caller invokes provider's functions with a block id, and when the error is returned they already know the block id's value
  • it allows converting custom Geth RPC errors into BlockNotFound in the From implementation

@0xNeshi 0xNeshi self-assigned this Jan 15, 2026
LeoPatOZ
LeoPatOZ reviewed Jan 15, 2026
View reviewed changes
@0xNeshi 0xNeshi requested a review from LeoPatOZ January 15, 2026 10:48
@0xNeshi 0xNeshi merged commit c725a87 into main Jan 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LeoPatOZ LeoPatOZ LeoPatOZ approved these changes

@pepebndc pepebndc Awaiting requested review from pepebndc pepebndc is a code owner

Assignees

@0xNeshi 0xNeshi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xNeshi @LeoPatOZ