Fix l2 SinkC #45
Merged
Fix l2 SinkC #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously io.c.ready is true when !hasData && io.task.ready wishing that Release can be sent directly to ReqArb if io.task.ready However, io.task.bits has taskArb.out as a higher priority option that prevents Release from being directly sent In such case, we should not accept Release in the first place (bug occurs when Release is accepted and allocated to an entry chosen by taskArb, thus this entry is invalid at the next cycle, and Release kept by this entry is invalidated as well)
Ivyfeather
requested review from
wakafa1,
linjuanZ and
cailuoshan
and removed request for
wakafa1
linjuanZ
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.