reset valve setting when valve status changes to be a fixed status (OPEN/CLOSED) by controls #66
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary
In EPANET's control system, there's a bug when sequencing valve controls in the following pattern:
In this case, the third control command (returning to the original numeric setting) is not properly executed.
Detailed Description
Problem Scenario
When implementing valve controls with this sequence:
The third control command (setting back to 56 at 2:00) fails to take effect.
Expected Behavior
All three control commands should be executed in sequence:
Actual Behavior
Only the first two controls are executed:
Solution
When change the valve status to a fixed status (OPEN/CLOSED), the
setting
value should be reset to be 0.0.