Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add column headings for sections in INP file #802

Merged

Conversation

YuChunTsao
Copy link
Contributor

This commit includes the following changes:

  • Column headings have been added for each section in the INP file.
  • The alignment of the values has been updated to match these headings.

These enhancements improve readability and understanding of the INP file.

This commit includes the following changes:
- Column headings have been added for each section in the INP file.
- The alignment of the values has been updated to match these headings.

These enhancements improve readability and understanding of the INP file.
@LRossman
Copy link
Collaborator

@YuChunTsao I have two suggestions:

  1. Use two semi-colons (;;) instead of just one to begin each heading line. This will make it easier for an input parser to identify a heading line and not confuse it with a comment.
  2. Change the "Factors" column heading in the [PATTERNS] section to "Multipliers" since that is the term used in the manual and the GUI.

@YuChunTsao
Copy link
Contributor Author

YuChunTsao commented Jun 18, 2024

@LRossman

Thank you for your suggestions.

  1. I've added two semicolons at the start of each heading line.
  2. After reviewing the code, I noticed that Multipliers had already been used in the [PATTERNS] section as per commit 317990a.

@LRossman LRossman merged commit 59f7295 into OpenWaterAnalytics:dev Jun 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants