Skip to content

Add base64 as gem dependencies for Ruby 3.4 #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

ekohl
Copy link
Contributor

@ekohl ekohl commented Jun 4, 2025

With Ruby 3.4 the base64 gem changed from a default gem to a bundled gem. This means it needs to be specified as a dependency.

@ekohl ekohl added the bug Something isn't working label Jun 4, 2025
bastelfreak
bastelfreak previously approved these changes Jun 4, 2025
@ekohl
Copy link
Contributor Author

ekohl commented Jun 4, 2025

#99 for he RuboCop naming change.

ekohl added 3 commits June 5, 2025 10:01
With Ruby 3.4 the base64 gem changed from a default gem to a bundled
gem. This means it needs to be specified as a dependency.
Since Ruby 3.4 the syslog gem changed from a default gem to a bundled
gem.

syslog is used to determine if the system is posix. On Windows it will
still fail to load the actual extension so the detection still works.
@ekohl ekohl force-pushed the add-base64-gem-dep branch from c52cb43 to 6fcc677 Compare June 5, 2025 08:10
@ekohl ekohl linked an issue Jun 5, 2025 that may be closed by this pull request
1 task
@ekohl ekohl changed the title Add base64 as a gem dependency Add base64 and syslog as gem dependencies for Ruby 3.4 Jun 5, 2025
@bastelfreak bastelfreak merged commit e307a27 into OpenVoxProject:main Jun 5, 2025
7 of 11 checks passed
@bastelfreak
Copy link
Contributor

reverted syslog in #110, so adjusted the title

@bastelfreak bastelfreak changed the title Add base64 and syslog as gem dependencies for Ruby 3.4 Add base64 as gem dependencies for Ruby 3.4 Jun 6, 2025
@ekohl ekohl deleted the add-base64-gem-dep branch June 7, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: syslog gem presence is used to determine POSIX
2 participants