Skip to content

Fix CI on JRuby #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix CI on JRuby #106

wants to merge 1 commit into from

Conversation

smortex
Copy link
Contributor

@smortex smortex commented Jun 5, 2025

No description provided.

@smortex
Do not add a dependency on syslog for JRuby
a30cad0 
JRuby has its own syslog implementation and adding support for JRuby in
the syslog gem is still an open issue.  Ignore this runtime dependency
if the platform is JRuby to allow bundling in JRuby.
@smortex smortex mentioned this pull request Jun 5, 2025
Closed
@bastelfreak bastelfreak requested a review from ekohl June 5, 2025 19:57
ekohl
ekohl reviewed Jun 5, 2025
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to work for dependencies because it will be evaluated at build time. So on Rubygems it will be there (when built on mri) or not (built on JRuby). Perhaps this needs to be fixed in syslog itself?

@ekohl
Copy link
Contributor

ekohl commented Jun 10, 2025

We ended up dropping the dependency in #110

@ekohl ekohl closed this Jun 10, 2025
@ekohl ekohl deleted the fix-jruby-syslog branch June 10, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smortex @ekohl