Skip to content

GCG: move it to dedicated gem group #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

bastelfreak
Copy link
Contributor

That allows us to skip the installation. It also has dependencies that are incompatible with JRuby.

Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 for not installing it by default.

In Rakefile when the gem can't be loaded it mentions that you need to install with the packaging group. That would no longer be true after this.

That allows us to skip the installation. It also has dependencies that
are incompatible with JRuby.
@bastelfreak
Copy link
Contributor Author

@ekohl fixed the Rakefile

@bastelfreak bastelfreak enabled auto-merge June 5, 2025 09:18
@bastelfreak bastelfreak merged commit 63dae66 into OpenVoxProject:main Jun 5, 2025
9 of 11 checks passed
@bastelfreak bastelfreak deleted the gcg branch June 5, 2025 09:18
Copy link

github-actions bot commented Jun 6, 2025

GitHub Actions is not permitted to create or approve pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants