Reflect Ruby 3.4 stack trace changes

[ekohl]

Ruby 3.4 changed the stack frame formatting and that meant it no longer recognized the Puppet stack frames. This updates the regex for the new format.

[ekohl]

Documenting my findings.

We have this code:

puppet/spec/unit/util/logging_spec.rb

Lines 17 to 26 in b35bea4

	def raise_error(exception_class)
	case exception_class
	when Puppet::ParseErrorWithIssue
	raise exception_class.new('Oops', '/tmp/test.pp', 30, 15, nil, :SYNTAX_ERROR)
	when Puppet::ParseError
	raise exception_class.new('Oops', '/tmp/test.pp', 30, 15)
	else
	raise exception_class.new('Oops')
	end
	end

But that can never work because that's not how you match exceptions. Minimal reproducer:

class MyException < StandardError; end

def raise_error(exception_class)
  case exception_class
  when MyException
    puts 'Match'
  else
    puts 'No match'
  end
end

raise_error(MyException)

This is because even RuntimeError === RuntimeError returns false.

But that just means it's equivalent to raise exception_class.new('Oops') which is still an instance of Puppet::ParseErrorWithIssue.

My feeling is that one of https://rubyreferences.github.io/rubychanges/3.4.html#backtrace-related-changes has an effect on this, but I can't figure out what.