fix CRL extension update by using ASN.1 INTEGER#26
Merged
corporate-gadfly merged 1 commit intoOpenVoxProject:mainfrom Feb 21, 2026
Merged
Conversation
1 task
corporate-gadfly
force-pushed
the
crl-extension-update
branch
2 times, most recently
from
a284542 to
3942a2b
Compare
smortex
approved these changes
Feb 21, 2026
Member
smortex
left a comment
smortex
left a comment
There was a problem hiding this comment.
Looks good. Given the breakage, I understand the need for caution, but maybe we can lower the number of checks before merging because I don't think that there is much values testing 100 increments rather than 2 or 3 😄
- use ASN.1 INTEGER with DER INTEGER tag to stay compatible with JDK's X509 CRL extension parsing before this commit, we were seeing plain integers in the CRL extension: 35 36 39 │ │ └── '9' (0x39) │ └───── '6' (0x36) └──────── '5' (0x35) after: 02 02 02 39 │ │ └──── 569 = 0x0239 │ └─────── length: 2 bytes └────────── tag: INTEGER - add spec for testing DER INTEGER tag
corporate-gadfly
force-pushed
the
crl-extension-update
branch
from
3942a2b to
06dccc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use ASN.1 INTEGER with DER INTEGER tag to stay compatible with JDK's X509 CRL extension parsing
before this commit, we were seeing plain integers in the CRL extension:
after: