Skip to content

Remove duplicate rspec/rake from Gemfile & remove unused pry/bundler dependency #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 4 commits into from
Feb 20, 2026
Merged

Remove duplicate rspec/rake from Gemfile & remove unused pry/bundler dependency #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d754e3
Remove duplicate rspec/rake from Gemfile
bastelfreak Feb 20, 2026
9e03894
remove bundler dependency
bastelfreak Feb 20, 2026
216c541
CI: Fix job title
bastelfreak Feb 20, 2026
0c1a30f
remove unused pry dependency
bastelfreak Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/unit_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
- name: Checkout current PR
uses: actions/checkout@v6

- name: Rspec checks
- name: Install Ruby ${{ matrix.cfg.ruby }}
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
Expand Down
7 changes: 0 additions & 7 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@ git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
gemspec

gem 'hocon', '~> 1.2', require: false
gem 'rake', '~> 13.0', require: false
gem 'rspec', '~> 3.4', require: false

group(:development, optional: true) do
gem 'pry'
gem 'pry-byebug'
end

group(:release, optional: true) do
gem 'faraday-retry', require: false
Expand Down
2 changes: 0 additions & 2 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
require "bundler/gem_tasks"

Dir.glob(File.join('tasks/**/*.rake')).each { |file| load file }

task default: :spec
Expand Down
5 changes: 2 additions & 3 deletions openvoxserver-ca.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ Gem::Specification.new do |spec|

spec.add_runtime_dependency "openfact", [">= 5.0.0", "< 6"]

spec.add_development_dependency "bundler", ">= 1.16"
spec.add_development_dependency "rake", ">= 12.3.3"
spec.add_development_dependency "rspec", "~> 3.0"
spec.add_development_dependency "rake", "~> 13.0"
spec.add_development_dependency "rspec", "~> 3.4"

# openvoxserver 7 uses jruby 9.3 which is compatible with MRI ruby 2.6
spec.required_ruby_version = '>= 2.6.0'
Expand Down