Skip to content

rack-test: Allow 2.x #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bastelfreak merged 2 commits into from
Sep 19, 2025
Merged

rack-test: Allow 2.x #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96e16aa
Ruby error: Adjust pattern matching to newer ruby/rubygems
bastelfreak Sep 19, 2025
c302e9f
rack-test: Allow 2.x
bastelfreak Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ gem "paint", "~> 2.2"
group(:test) do
gem "beaker-hostgenerator"
gem "mocha", '~> 1.4.0'
gem "rack-test", '~> 1.0'
gem "rack-test", '>= 1', '< 3'
gem 'rspec-github', require: false
end

Expand Down
2 changes: 1 addition & 1 deletion spec/integration/apply_error_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
with_tempfile_containing('site', 'load_error()', '.pp') do |tempfile|
run_cli(%W[apply #{tempfile.path} --run-as root --sudo-password #{password}] + config_flags)
logs = @log_output.readlines
expect(logs).to include(/`require': cannot load such file -- fake \(LoadError\)/)
expect(logs).to include(/cannot load such file -- fake \(LoadError\)/)
expect(logs).to include(/Something's gone terribly wrong! STDERR is logged/)
end
end
Expand All @@ -53,7 +53,7 @@
let(:password) { conn_info('winrm')[:password] }
let(:tflags) { %w[--no-ssl --no-ssl-verify] }

it 'prints a helpful error if Puppet is not present', :winrm_agentless, :winrm do

Check warning on line 56 in spec/integration/apply_error_spec.rb

View workflow job for this annotation

GitHub Actions / Agentless (3.2) 

errors gracefully attempting to apply a manifest block over winrm prints a helpful error if Puppet is not present

Skipped: Skipping this test as it fails with a connection error until #3001 is fixed
skip "Skipping this test as it fails with a connection error until #3001 is fixed"
result = run_cli_json(%w[plan run basic::class] + config_flags)
error = result['details']['result_set'][0]['value']['_error']
Expand Down
Loading