-
Notifications
You must be signed in to change notification settings - Fork 6
Remove Puppet Enterprise leftovers #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ekohl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see some cases when you grep for pe- but we can probably ignore those.
resources/puppetlabs/lein-ezbake/template/global/tasks/build.rake
Outdated
Show resolved
Hide resolved
There's a bit of clojure stuff, but I'm not really sure how to properly clean that up :( and I didn't want to break it. |
That's also why in the past I didn't fully go through with it. I think this is good enough for now. |
resources/puppetlabs/lein-ezbake/template/global/tasks/build.rake
Outdated
Show resolved
Hide resolved
| end | ||
|
|
||
| desc "trigger jenkins packaging job with local auth" | ||
| task :trigger_build_local_auth => "pl:fetch" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I looked at this job I wondered if we even need it at all. In fact, I questioned that wit the entire file because we don't have a Jenkins instance. So is it easier to get rid of it altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are a few rake tasks we don't use, I want to remove them in another PR
(cherry picked from commit fcbd7e9) This is cherry-picked from OpenVoxProject#61 and was originally added in OpenVoxProject#16 --- Delete more PE leftovers (cherry picked from commit 48036a8) this is cherry-picked from OpenVoxProject#61 and was originally added in OpenVoxProject#18
No description provided.