-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: standard naming for PyPi #14
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request involve modifications to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Outside diff range and nitpick comments (1)
setup.py (1)
71-72
: Consider using an organization email address.While the author name has been updated to "OpenVoiceOS", the contact email remains a personal email address. This might cause confusion about package ownership and support channels.
Consider using an organizational email address (e.g.,
contact@openvoiceos.org
or similar) to maintain consistency with the package ownership.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
setup.py
(2 hunks)
🔇 Additional comments (1)
setup.py (1)
Line range hint 11-14
: LGTM! Automated derivation maintains consistency.
The skill author and name are correctly derived from the URL, ensuring consistency across the package metadata and entry points.
@@ -3,9 +3,9 @@ | |||
from os import walk, path | |||
|
|||
BASEDIR = path.abspath(path.dirname(__file__)) | |||
URL = "https://github.com/mikejgray/skill-randomness" | |||
URL = "https://github.com/openvoiceos/skill-ovos-randomness" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Breaking changes detected in package references
The verification revealed several instances where the old package name needs to be updated:
- Test files still reference the old skill ID
skill-randomness.mikejgray
:test/test_skill.py
: Contains hardcoded references in test cases- Directory structure still uses
skill_randomness
instead ofovos_skill_randomness
The package renaming requires additional changes beyond setup.py to maintain consistency and prevent test failures.
🔗 Analysis chain
LGTM! Note: Breaking change in package name.
The package renaming from skill-randomness
to ovos-skill-randomness
follows the standard OpenVoiceOS naming convention, improving discoverability. However, this is a breaking change that will affect existing installations.
Let's verify if there are any existing installations or references to the old package name:
Also applies to: 8-8
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any references to the old package name in the codebase
rg "skill-randomness" --type-add 'requirements:*.txt' --type requirements
Length of output: 73
Script:
#!/bin/bash
# Let's try a broader search for any requirements files
fd "requirements.txt|setup.py" --type f --exec cat {}
# Also search for any potential references to the package name in other files
rg -i "skill.?randomness" --type py
Length of output: 4289
* feat: first PyPi release (#6) * feat: first PyPi release * fix enclosure blink (#7) * automations/translations * translations/allow_UNUSED_keywords * fix:long description (#11) semver automations fail if dont use full path for README * chore: new automations (#10) * bump minimum version - icepool is only supported in Python 3.10+ * chore(automations): tidy up and get a release out (#13) * Increment Version to 0.0.2a1 * Update Changelog * fix: standard naming for PyPi (#14) * Increment Version to 0.0.3a1 * Update Changelog * feat: support more Python versions, fix workflows (#15) * feat: support more Python versions (3.9+), fix workflows * Increment Version to 0.1.0a1 * Update Changelog * fix: enable language support in LF * address odd verison.py * chore: remove old translation test file --------- Co-authored-by: JarbasAI <33701864+JarbasAl@users.noreply.github.com> Co-authored-by: miro <jarbasai@mailfence.com> Co-authored-by: mikejgray <mikejgray@users.noreply.github.com>
Summary by CodeRabbit