feat: m2v pipeline #681
feat: m2v pipeline #681
Conversation
WalkthroughThe IntentService class was updated to optionally support a new Model2VecIntentPipeline intent matcher, alongside existing pipelines. Conditional imports, initialization, and pipeline registration were added. Two new plugin dependencies were also introduced in the requirements file to support these changes. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant IntentService
participant Model2VecIntentPipeline
User->>IntentService: Initialize with config
IntentService->>IntentService: _load_pipeline_plugins()
alt Model2VecIntentPipeline available
IntentService->>Model2VecIntentPipeline: Instantiate
Model2VecIntentPipeline-->>IntentService: Instance assigned to _m2v
end
User->>IntentService: get_pipeline(session)
IntentService->>IntentService: Add matchers (including _m2v.match_high if present)
IntentService-->>User: Return pipeline matchers
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Docstrings generation was requested by @JarbasAl. * #681 (comment) The following files were modified: * `ovos_core/intent_services/__init__.py`
|
Note Generated docstrings for this pull request at #682 |
Docstrings generation was requested by @JarbasAl. * #681 (comment) The following files were modified: * `ovos_core/intent_services/__init__.py` Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ovos_core/intent_services/__init__.py (1)
43-44: Consider removing TODO commentThis TODO comment refers to a previous PR (#570) and may not be relevant to the current changes. Consider removing it or updating it to reflect the current status.
-# TODO - to be dropped once pluginified -# just a placeholder during alphas until https://github.com/OpenVoiceOS/ovos-core/pull/570
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ovos_core/intent_services/__init__.py(7 hunks)requirements/plugins.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: license_tests
- GitHub Check: end2end_tests (3.11)
🔇 Additional comments (7)
requirements/plugins.txt (1)
8-9: New dependencies added for Model2Vec and Ollama intent pipelinesThese new dependencies enable the integration of Model2Vec and Ollama intent processing pipelines into the core system. The version constraints appropriately allow minor updates while preventing major version changes that might introduce breaking changes.
ovos_core/intent_services/__init__.py (6)
49-52: Conditional import for Model2VecIntentPipelineThis gracefully handles the Model2Vec pipeline as an optional dependency, following the same pattern as the existing LLMIntentPipeline.
87-87: Initialize _m2v attributeThe new _m2v attribute is properly initialized to None, consistent with the initialization pattern used for other pipeline components.
151-152: Conditional loading of Model2VecIntentPipelineThe Model2Vec pipeline is properly initialized with the appropriate bus and configuration parameters, following the established pattern for other pipeline components.
267-268: Register Model2Vec matcher in pipelineThe high-priority matcher function from the Model2Vec pipeline is correctly added to the dictionary of available matchers, making it available for the intent matching pipeline.
64-70: Updated docstring to include Model2Vec pipelineThe docstring has been appropriately updated to include the Model2Vec pipeline in the list of supported intent matching pipelines.
117-119: Updated docstring for _load_pipeline_pluginsThe docstring has been properly updated to include the Model2Vec pipeline in the list of supported pipelines.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #681 +/- ##
==========================================
- Coverage 75.33% 69.74% -5.60%
==========================================
Files 15 15
Lines 3094 1699 -1395
==========================================
- Hits 2331 1185 -1146
+ Misses 763 514 -249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
https://github.com/TigreGotico/ovos-m2v-pipeline
Summary by CodeRabbit