fix: intent api indentation error

[JarbasAl]

remove deprecated sigint handler from mycroft times

Summary by CodeRabbit

• Bug Fixes

  • Fixed the logic for handling user intent processing to ensure all intended actions are fully evaluated.

• Refactor

  • Revised internal processing to streamline application execution and improve overall stability.

[coderabbitai]

Walkthrough

This pull request removes a call to a signal reset function from the main execution path and adjusts the control flow in the intent handling logic. The signal handler reset import and its invocation are deleted, indicating a shift in SIGINT management. Additionally, the return statement in an intent-processing method is re-indented to ensure it executes only when a condition is met. No new functionality is introduced.

Changes

File(s)	Change Summary
ovos_core/__main__.py	Removed the reset_sigint_handler import and its function call, indicating an update to SIGINT signal handling.
ovos_core/intent_services/__init__.py	Adjusted the return statement indentation in the handle_get_intent method so it executes only after a successful condition check during intent processing.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant IntentService
    Client->>IntentService: handle_get_intent(intent_data)
    loop Iterate over potential intents
      IntentService->>IntentService: Evaluate intent match condition
      alt Condition met
        IntentService->>Client: Emit intent reply and return value
      else Condition not met
        IntentService->>IntentService: Continue evaluating next intent
      end
    end

Loading

Suggested labels

fix

Poem

Oh, what a change in code today!
I hopped along to clear the way.
Removed a call to catch the sign,
And re-indented to make it fine.
With joyful hops, I code away! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a901b8 and deb2015.

📒 Files selected for processing (2)

• ovos_core/__main__.py (0 hunks)
• ovos_core/intent_services/__init__.py (1 hunks)

💤 Files with no reviewable changes (1)

• ovos_core/main.py

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: license_tests
• GitHub Check: end2end_tests (3.9)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.10%. Comparing base (23f0bab) to head (deb2015).
Report is 189 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #653      +/-   ##
==========================================
- Coverage   75.33%   71.10%   -4.24%     
==========================================
  Files          15       15              
  Lines        3094     1651    -1443     
==========================================
- Hits         2331     1174    -1157     
+ Misses        763      477     -286     

Flag	Coverage Δ
end2end	54.63% <0.00%> (?)
unittests	47.66% <100.00%> (-27.68%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.