refactor/deprecate mycroft.tts #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
commented
Nov 5, 2021
JarbasAl
force-pushed
the
refactor/tts_cache
branch
from
cafc09a
to
a43d059
Compare
removes unused code, tts cache is handled by OPM the implementation was mimic2 specific, nothing should be importing it in the wild, opm/mimic2_plugin do not use the deleted classes utility methods are kept for backwards compat, hash funcs and mycroft.util.file_utils are good candidates for merging with ovos_utils
JarbasAl
force-pushed
the
refactor/tts_cache
branch
from
a43d059
to
6b30c53
Compare
|
depends on OpenVoiceOS/ovos-plugin-manager#15 and OpenVoiceOS/ovos-utils#9 further reduces duplicated code psutil is no longer a requirement, was used in a single method and replaced with shutil (in linked PRs) |
JarbasAl
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bumps ovos plugin manager to 0.0.3a1 and removes duplicted code
latest mycroft-core tts cache implementation ported in OpenVoiceOS/ovos-plugin-manager#15
psutil is no longer a mandatory requirement