Fix: fix and refactor st41 possible errors #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawidWesierski4
requested review from
PanKaker,
Sakoram,
skolelis and
Falron98
as code owners
* Fix possible null pointer reference in app_tx_fmd_init * Fix: coveriy out of band issue * Increate quality of tx_fastmetadata_session_build_packet code * coverity fix: fixing less-than-zero comparison * add st41 context app multithread access error * Add error message when the st41 functionality of RxTx app detects multithread access to the contex app resource, which should not be shared. Fixes: c43152d Co-developed-by: Aleksandr Ivanov <aleksandr.ivanov@intel.com> Co-developed-by: Kolelis, Szymon <szymon.kolelis@intel.com>
DawidWesierski4
force-pushed
the
st41_refactor
branch
from
dc5fa70
to
c3c99fc
Compare
skolelis
reviewed
Sep 17, 2024
| @@ -426,6 +430,12 @@ static void tx_fastmetadata_session_build_packet( | |||
| uint16_t data_item_length = | |||
| (data_item_length_bytes + 3) / 4; /* expressed in number of 4-byte words */ | |||
|
|
|||
| if (rte_pktmbuf_data_len(pkt) < sizeof(*hdr) + data_item_length) { | |||
There was a problem hiding this comment.
instead of (data_item_length), there should be (data_item_length * 4) used.
DawidWesierski4
added a commit
to DawidWesierski4/Media-Transport-Library
that referenced
this pull request
Sep 18, 2024
* Fix possible null pointer reference in app_tx_fmd_init * Fix: coveriy out of band issue * Increate quality of tx_fastmetadata_session_build_packet code * coverity fix: fixing less-than-zero comparison * add st41 context app multithread access error * Add error message when the st41 functionality of RxTx app detects multithread access to the contex app resource, which should not be shared. Fixes: c43152d Co-developed-by: Aleksandr Ivanov <aleksandr.ivanov@intel.com> Co-developed-by: Kolelis, Szymon <szymon.kolelis@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix possible null pointer reference in app_tx_fmd_init
Fix: coveriy out of band issue
Increate quality of tx_fastmetadata_session_build_packet code
coverity fix: fixing less-than-zero comparison
add st41 context app multithread access error
Add error message when the st41 functionality of RxTx app detects multithread access to the contex
app resource, which should not be shared.
Fixes: c43152d
Co-developed-by: Aleksandr Ivanov aleksandr.ivanov@intel.com
Co-developed-by: Kolelis, Szymon szymon.kolelis@intel.com