Merged
Conversation
* Please read their CHANGELOGs * Delete op retested
* *marked* seems to have finally fixed tables... seems 1 to 1... still has issues with html tags per OpenUserJS#1775 via markedjs/marked#2217 and markedjs/marked#2471
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jun 24, 2022
* Previews seem to be severely busted in v4.x ... will have to decide if a rollback or other change is needed, or if a different dep needs to be used [*markdown-it](https://www.npmjs.com/package/markdown-it) for example. I do prefer regex speed in *markdown* but a lot of errors. Post OpenUserJS#1957 and may apply to OpenUserJS#1775 Note(s): * `marked.min.js` is made by https://github.com/markedjs/marked/blob/078352f2198f9a2359b9c66286007202be919be1/Makefile#L3 as referenced in https://github.com/markedjs/marked/blob/078352f2198f9a2359b9c66286007202be919be1/README.md#usage
Martii
added a commit
that referenced
this pull request
Jun 24, 2022
* Previews seem to be severely busted in v4.x ... will have to decide if a rollback or other change is needed, or if a different dep needs to be used [*markdown-it](https://www.npmjs.com/package/markdown-it) for example. I do prefer regex speed in *markdown* but a lot of errors. Post #1957 and may apply to #1775 Note(s): * `marked.min.js` is made by https://github.com/markedjs/marked/blob/078352f2198f9a2359b9c66286007202be919be1/Makefile#L3 as referenced in https://github.com/markedjs/marked/blob/078352f2198f9a2359b9c66286007202be919be1/README.md#usage Auto-merge
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jun 24, 2022
Applies to OpenUserJS#1965 *(not closing in case production doesn't work since prior inconsistent test results... will close if applicable)* Post OpenUserJS#1957 *(also may need to revert partial OpenUserJS#1964 shortly after full retest)*
Martii
added a commit
that referenced
this pull request
Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commit notes