Skip to content

Remove redundant sequence_data validation in check_for_sequence_data #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Remove redundant sequence_data validation in check_for_sequence_data #203

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32ab90a
Initial plan
Copilot Dec 8, 2025
dca5315
Remove redundant sequence_data check in helpers.py
Copilot Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,9 +1106,6 @@ async def check_for_sequence_data(isolate, split_on_fasta_headers=True):
# Reconstruct FASTA format for storage
sequence_data = f">{sequence_found.description}\n{str(sequence_found.seq)}"

if not sequence_data.strip():
return False, f"No sequence data found for isolate '{isolate_sample_id}'"

# 7. If file and header found, pass to save_sequence_data for processing
new_object_id = await save_sequence_data(sequence_data, isolate['submission_id'], isolate['id'])

Expand Down