Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Zulu builds of OpenJDK in GH actions #932

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

carldea
Copy link
Contributor

@carldea carldea commented Aug 30, 2021

The AdoptOpenJDK has been discontinued since July 2021. When using Zulu OpenJDK builds gets you all the latest and greatest (TCK Tested) builds for all versions of OpenJDK.

https://adoptopenjdk.net

"24th July 2021: AdoptOpenJDK is moving to the Eclipse Foundation and rebranding.
Our July 2021 and future releases will come from Adoptium.net"

@dennisguse
Copy link
Member

@carldea can you squash the two commits?

@dennisguse
Copy link
Member

@carldea And why not use Temurin?
TeamNewPipe/NewPipe#6995

The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK.
@carldea
Copy link
Contributor Author

carldea commented Aug 30, 2021

Squash completed.

@carldea can you squash the two commits?

I completed the squash.

@carldea
Copy link
Contributor Author

carldea commented Aug 31, 2021

@carldea And why not use Temurin?
TeamNewPipe/NewPipe#6995

No reason. Except Temurin doesn't support every version of OpenJDK if you ever decide to have your app run on different versions of Java.

Some customers in production environments will have a better peace of mind when their app is able to run on many (updated/patched) versions of Java. I guess it's really about comfort level, or level of risk if you plan on deploying your app in production or built with a particular distro. At the end of the day, both distros are TCK tested and built with the same OpenJDK source.

I chose Zulu builds because they are very mature (excellent track record) with security updates and TCK tested since GitHub actions setup-java@v1.

Zulu builds offer every version of OpenJDK from 6 to 18-ea. For example 8, 11, 17-ea (LTS versions) are all supported (and versions in between) with the latest security updates.

It's great to have choice. You could alway try it out, and if you're not happy just change it. Or I could add a matrix (array) to the workflow to build on artifacts for both distros. Since runners run in parallel anyways.
:-)

@dennisguse dennisguse merged commit 038e8d3 into OpenTracksApp:main Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants