Allow per-clip and per-track colors #14
Conversation
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
…dots. Signed-off-by: Joshua Minor <joshm@pixar.com>
| if (item->metadata().has_key("raven") && | ||
| item->metadata()["raven"].type() == typeid(otio::AnyDictionary)) | ||
| { | ||
| auto raven_md = otio::any_cast<otio::AnyDictionary>(item->metadata()["raven"]); |
There was a problem hiding this comment.
Is there a more elegant way to get/set a field within a nested metadata dictionary? This feels very awkward compared to the Python equivalent.
There was a problem hiding this comment.
AFAIK, what you are doing is as compact as it gets. I think we'd have to do some work with template and operator magic to create a kind of DSL that would let you index deeply into nested dictionaries.
Signed-off-by: Joshua Minor <joshm@pixar.com>
Signed-off-by: Joshua Minor <joshm@pixar.com>
|
Our Marker schema has a color property (with the enumeration you're using here). I'm wondering if it's time to talk about migrating the property higher in the schema, so that it becomes available to any composable element? |
|
Very cool! I wonder if this should be the beginning of discussion about a custom schema for Raven specific metadata. |
|
Discussion about OTIO schema for per-clip colors can continue here: AcademySoftwareFoundation/OpenTimelineIO#1614 |
* Per-clip and per-track colors in the UI * Highlight selected items in white. * Invert effect label color based on fill color * Render effect bubbles smaller, and if there's not much room, just as dots. Signed-off-by: Joshua Minor <joshm@pixar.com>
3 participants
This begins to address #11
For now, this stores colors in a metadata field:
"raven": {"color": "CYAN"}Here's what it looks like.
