New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #354: Improve length check for string literal properties #355

Merged

glx22 merged 1 commit into OpenTTD:master from glx22:fix_354

Jan 6, 2025

Contributor

glx22 commented Jan 6, 2025

Length check for string literal properties is dumb, it uses len() so len('NML_') is 4 and len('\FFNML') is 6.

Use grfstrings.get_string_size() so the length checks are done on actual length in bytes.


          Fix OpenTTD#354: Improve length check for string literal properties

f14dca0

PeterN approved these changes

View reviewed changes

glx22 merged commit f97de8b into OpenTTD:master

21 checks passed

glx22 deleted the fix_354 branch

January 6, 2025 22:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet