Skip to content

Conversation

@Kyle-Ye
Copy link
Collaborator

@Kyle-Ye Kyle-Ye commented Jan 18, 2026

No description provided.

@augmentcode
Copy link

augmentcode bot commented Jan 18, 2026

🤖 Augment PR Summary

Summary: This PR expands content-transition plumbing and adds a snapshot UI test for AsyncImage, while addressing a display-list positioning issue.

Changes:

  • Introduces a WIP ContentTransition implementation with environment integration and related effect/group scaffolding.
  • Adds InterpolatableContent and an InterpolatedDisplayList rule to support content interpolation workflows.
  • Hooks Image.Resolved into the interpolation path via InterpolatableContent and applies the interpolator group during display-list generation.
  • Removes older placeholder/conflicting ContentTransitionEffect stubs and replaces an unimplemented EnvironmentValues.contentTransitionStyle extension.
  • Extends snapshot testing helpers to support snapshotting platform view controllers.
  • Adds an AsyncImage snapshot test plus a bundled logo.png resource for local loading.

Technical Notes: A number of transition/interpolation components are explicitly marked WIP/blocked; the current implementation focuses on wiring and positioning behavior rather than full transition semantics.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

// FIXME
let result: [DisplayList.Item] = list?.items.map {
var item = $0
item.frame.origin = .init(position - containerPosition)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In InterpolatedDisplayList.updateValue, assigning item.frame.origin to position - containerPosition overwrites any existing per-item origin from the source DisplayList (e.g. non-zero local frames from shape/image rendering). If the wrapped list isn’t guaranteed to be zero-origin, this could shift content; worth double-checking whether the intention is to translate existing origins rather than replace them.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 0% with 201 lines in your changes missing coverage. Please review.
✅ Project coverage is 27.86%. Comparing base (e34a6a5) to head (3c8e4a8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...OpenSwiftUICore/Render/InterpolatableContent.swift 0.00% 85 Missing ⚠️
...ICore/Animation/Transition/ContentTransition.swift 0.00% 67 Missing ⚠️
...SwiftUI/Render/DisplayList/AppKitDisplayList.swift 0.00% 31 Missing ⚠️
...ces/OpenSwiftUICore/View/Image/ResolvedImage.swift 0.00% 11 Missing ⚠️
...enSwiftUICore/Render/DisplayList/DisplayList.swift 0.00% 5 Missing ⚠️
Sources/OpenSwiftUICore/Render/SymbolEffect.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #733      +/-   ##
==========================================
- Coverage   27.97%   27.86%   -0.12%     
==========================================
  Files         603      604       +1     
  Lines       37171    37360     +189     
==========================================
+ Hits        10399    10410      +11     
- Misses      26772    26950     +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit a781956 into main Jan 18, 2026
5 of 8 checks passed
@Kyle-Ye Kyle-Ye deleted the feature/InterpolatableContent branch January 18, 2026 19:44
@Kyle-Ye Kyle-Ye linked an issue Jan 18, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Image support

2 participants