-
Notifications
You must be signed in to change notification settings - Fork 58
Fix position issue and add AsyncImage UI test case #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Augment PR SummarySummary: This PR expands content-transition plumbing and adds a snapshot UI test for Changes:
Technical Notes: A number of transition/interpolation components are explicitly marked WIP/blocked; the current implementation focuses on wiring and positioning behavior rather than full transition semantics. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // FIXME | ||
| let result: [DisplayList.Item] = list?.items.map { | ||
| var item = $0 | ||
| item.frame.origin = .init(position - containerPosition) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In InterpolatedDisplayList.updateValue, assigning item.frame.origin to position - containerPosition overwrites any existing per-item origin from the source DisplayList (e.g. non-zero local frames from shape/image rendering). If the wrapped list isn’t guaranteed to be zero-origin, this could shift content; worth double-checking whether the intention is to translate existing origins rather than replace them.
🤖 Was this useful? React with 👍 or 👎
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 27.97% 27.86% -0.12%
==========================================
Files 603 604 +1
Lines 37171 37360 +189
==========================================
+ Hits 10399 10410 +11
- Misses 26772 26950 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.