Skip to content

Conversation

jcmosc
Copy link
Contributor

@jcmosc jcmosc commented Aug 24, 2025

This adds a OGUnownedGraphContextRef type which is actually a pointer to a OG::Graph instance.

The OGSubgraphGetGraph function, which is now unimplemented, needs to look up the OG::Graph::Context instance from a map of context IDs to Context instances stored on the OG::Graph instance.

The one inconsistency is OGGraphContextGetGraph which still takes a raw pointer to a OG::Graph::Context instance. Though this function is only called from AGSubgraphGetGraph and looks to be inlined.

Copy link

codecov bot commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.92%. Comparing base (65a976c) to head (5dd2d74).

Files with missing lines Patch % Lines
...rces/OpenGraph/Attribute/Attribute/Attribute.swift 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #173      +/-   ##
========================================
+ Coverage   4.89%   4.92%   +0.02%     
========================================
  Files         28      28              
  Lines        817     813       -4     
========================================
  Hits          40      40              
+ Misses       777     773       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant