Intern attribute type #173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #173 +/- ##
========================================
+ Coverage 4.81% 4.83% +0.02%
========================================
Files 28 28
Lines 831 827 -4
========================================
Hits 40 40
+ Misses 791 787 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kyle-Ye
requested changes
Sep 7, 2025
Contributor
Kyle-Ye
left a comment
Kyle-Ye
left a comment
There was a problem hiding this comment.
Rebase to use OAG instead of OG to fix conflict.
# Conflicts: # Sources/OpenGraphCxx/Graph/OGGraph.cpp # Sources/OpenGraphCxx/Graph/OGGraphContext.cpp # Sources/OpenGraphCxx/Graph/OGSubgraph.cpp # Sources/OpenGraphCxx/Graph/Subgraph.cpp # Sources/OpenGraphCxx/include/OpenGraph/OGGraph.h # Sources/OpenGraphCxx/include/OpenGraph/OGGraphContext.h # Sources/OpenGraphCxx/include/OpenGraph/OGSubgraph.h # Sources/OpenGraphCxx/include/OpenGraphCxx/Graph/Graph.hpp # Sources/OpenGraphCxx/include/OpenGraphCxx/Graph/Subgraph.hpp
jcmosc
force-pushed
the
intern-attribute-type
branch
from
5dd2d74 to
5aa6545
Compare
Contributor
|
@claude review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
OGUnownedGraphContextReftype which is actually a pointer to aOG::Graphinstance.The
OGSubgraphGetGraphfunction, which is now unimplemented, needs to look up the OG::Graph::Context instance from a map of context IDs to Context instances stored on the OG::Graph instance.The one inconsistency is
OGGraphContextGetGraphwhich still takes a raw pointer to aOG::Graph::Contextinstance. Though this function is only called from AGSubgraphGetGraph and looks to be inlined.