Attribute interface updates #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
========================================
- Coverage 4.81% 4.75% -0.07%
========================================
Files 28 28
Lines 831 842 +11
========================================
Hits 40 40
- Misses 791 802 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Kyle-Ye
requested changes
Sep 7, 2025
Contributor
Kyle-Ye
left a comment
Kyle-Ye
left a comment
There was a problem hiding this comment.
- For added API, add compatibility test case to avoid future link error.
- Rebase to use OAG instead of OG to fix conflict.
# Conflicts: # Sources/OpenGraphCxx/Attribute/OGAttribute.cpp # Sources/OpenGraphCxx/include/OpenGraph/OGAttribute.h
…eRule and initial value
jcmosc
force-pushed
the
attribute-interface-updates
branch
from
37c0c02 to
f87f3f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.