Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch midpoint fix #1133

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

NickGuyver
Copy link
Contributor

Fix the bad midpoint, from 16 to 8 bit conversion, on analogs for Switch mode. Tested on Switch to be it's true center.

Fix the bad midpoint, from 16 to 8 bit conversion, on analogs for Switch mode. Tested on Switch to be it's true center.
@NickGuyver NickGuyver marked this pull request as draft September 15, 2024 01:07
@NickGuyver NickGuyver marked this pull request as ready for review September 15, 2024 22:22
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, takes care of rounding errors when we have a maximum value at dead center.

@arntsonl arntsonl merged commit 576c7b8 into OpenStickCommunity:main Sep 26, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants