Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Flatbox Rev.5 Config & Header Documentation #1099

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Updates Flatbox Rev.5 Config & Header Documentation #1099

merged 2 commits into from
Sep 17, 2024

Conversation

brettohland
Copy link
Contributor

This PR does the following:

  • Adds the missing column on BoardConfig.h which correlates the screen printed switch labels with their GPIO pins
    • Re-orders the rows to be ordered by the screen printed labels
  • Adds the screen printed labels, GPIO, and Input information to the Readme.md file

@brettohland
- Adds missing switch label documentation to BoardConfig header for F…
9b7cb48 
…latbox Rev 5

- Adds labels and pinouts to Flatbox Rev 5 Readme
arntsonl
arntsonl previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@arntsonl arntsonl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with these changes, I see how they reflect the PCB labeling vs. the config headers

@arntsonl
Copy link
Contributor

I like the way these look based on the PCB labeling. We can revert it if we need to, but it looks clean to my eyes

@arntsonl arntsonl merged commit 96e97b2 into OpenStickCommunity:main Sep 17, 2024
1 check passed
@brettohland brettohland deleted the flatbox-rev5-update branch September 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arntsonl arntsonl arntsonl left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettohland @arntsonl