Skip to content

Fix stats display #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moustachu merged 8 commits into from
Feb 28, 2019
Merged

Fix stats display #356

moustachu merged 8 commits into from
Feb 28, 2019

Conversation

@armandfardeau
Copy link
Collaborator

@armandfardeau armandfardeau commented Dec 4, 2018 •
edited
Loading

🎩 What? Why?

Fix stats display for debates and proposals

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

image

@ghost ghost assigned armandfardeau Dec 4, 2018
@ghost ghost added the needs-review label Dec 4, 2018
@lu-hamani lu-hamani self-requested a review December 5, 2018 08:23
lu-hamani
lu-hamani approved these changes Dec 5, 2018
View reviewed changes
Copy link

@lu-hamani lu-hamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine

lu-hamani
lu-hamani suggested changes Dec 5, 2018
View reviewed changes
Copy link

@lu-hamani lu-hamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet

@armandfardeau armandfardeau changed the title Fix stats display for debates WIP: Fix stats display for debates Dec 5, 2018
lu-hamani
lu-hamani previously approved these changes Dec 11, 2018
View reviewed changes
Copy link

@lu-hamani lu-hamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@armandfardeau armandfardeau changed the title WIP: Fix stats display for debates Fix stats display Dec 11, 2018
@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Feel free to notify @lu-hamani.

@stale stale bot added the wontfix under the radar label Jan 10, 2019
@lu-hamani lu-hamani removed the wontfix under the radar label Jan 11, 2019
@lu-hamani lu-hamani added this to the Late fixes 0.12 milestone Jan 17, 2019
moustachu
moustachu previously approved these changes Jan 17, 2019
View reviewed changes
@ghost ghost assigned moustachu Jan 17, 2019
@lu-hamani lu-hamani removed this from the Late fixes 0.12 milestone Feb 6, 2019
@lu-hamani
Copy link

lu-hamani commented Feb 25, 2019

@armandfardeau
Still there in 0.16

@lu-hamani lu-hamani mentioned this pull request Feb 25, 2019
Closed
13 tasks
@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Feb 26, 2019

@lu-hamani Merge on BCN, We should backport this on our 0.16
Do you still want to fix on 0.12?

moustachu
moustachu previously approved these changes Feb 28, 2019
View reviewed changes
@moustachu moustachu merged commit d5bbdcd into 0.12-stable Feb 28, 2019
@ghost ghost removed the needs-review label Feb 28, 2019
@moustachu moustachu deleted the Fix/stats-display branch February 28, 2019 15:30
moustachu added a commit that referenced this pull request Mar 2, 2019
@moustachu
✅ repair tests for #356
198bbf7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moustachu moustachu moustachu approved these changes

+1 more reviewer

@lu-hamani lu-hamani lu-hamani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@moustachu moustachu

@armandfardeau armandfardeau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@armandfardeau @lu-hamani @moustachu