Skip to content

0.12 stable budget with tests #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moustachu merged 54 commits into from
Nov 15, 2018
Merged

0.12 stable budget with tests #330

moustachu merged 54 commits into from
Nov 15, 2018

Conversation

@armandfardeau
Copy link
Collaborator

@armandfardeau armandfardeau commented Nov 5, 2018 •
edited
Loading

🎩 What? Why?

Budget component was not perfectly covered by tests, this can lead to regression.
We don't like regression.

See #247

📋 Subtasks

  • Add CHANGELOG entry
  • Add models tests
  • Add commands tests
  • Add forms tests
  • Add system tests

👻 GIF :

https://media.giphy.com/media/xTiTnqUxyWbsAXq7Ju/giphy.gif

armandfardeau and others added 30 commits September 10, 2018 11:26
@armandfardeau
move srcript to right file
706efcc
@armandfardeau
import js
ac5e1be
@armandfardeau
import style
f0a2102
@armandfardeau
import helper
046a6b2
@armandfardeau
import model
e12c4a6
@armandfardeau
Import views
c677336
@armandfardeau
Import extends
8910de2
@armandfardeau
import translation
e303270
@armandfardeau
import component settings
adfb439
@armandfardeau
import migration
ccd8ba4
@armandfardeau
Import extends
93edda9
@armandfardeau
move project file to right folder
326572b
@armandfardeau
Fix typo
79e6d82
@armandfardeau
Fix migration
d75cf5d
@armandfardeau
fix rubocop offenses
cefbd96
@armandfardeau
Fix lint offenses
3e9e3d4
@armandfardeau
Fix erblint offesense
6f37c0c
@armandfardeau
Build bundle.js
17eb74f
@armandfardeau
Fix commands and form tests
ea2164e
@armandfardeau
Fix method name
a76931f
@armandfardeau
Fix linter issue
9a25d4d
@armandfardeau
Fix css test
8a04085
@armandfardeau
Fix test
1626327
@armandfardeau
Fix lint offense
2c95f65
@armandfardeau
Fix missing translation
ffbc539
@armandfardeau
Merge branch '0.12-stable' into 0.12-stable-budget
c5b1014
@armandfardeau
Fix rubocop offense
329c4b3
@armandfardeau
remove TODO
e395008
@armandfardeau
use proper breakpoint
614534f
@armandfardeau
Add readme entry
0c19e5b
@armandfardeau armandfardeau force-pushed the 0.12-stable-budget-with-tests branch from 7eba59d to 4af7866 Compare November 6, 2018 22:59
@lu-hamani lu-hamani mentioned this pull request Nov 12, 2018
Closed
@armandfardeau armandfardeau changed the title WIP: 0.12 stable budget with tests 0.12 stable budget with tests Nov 13, 2018
@armandfardeau armandfardeau force-pushed the 0.12-stable-budget-with-tests branch 2 times, most recently from 0f082d8 to f1a2492 Compare November 13, 2018 14:51
lu-hamani
lu-hamani approved these changes Nov 14, 2018
View reviewed changes
Copy link

@lu-hamani lu-hamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@lu-hamani lu-hamani added this to the BP enhancements milestone Nov 14, 2018
moustachu
moustachu approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@moustachu moustachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@moustachu moustachu merged commit 562b660 into 0.12-stable Nov 15, 2018
@ghost ghost removed the needs-review label Nov 15, 2018
moustachu added a commit to OpenSourcePolitics/osp-app that referenced this pull request Nov 15, 2018
@moustachu
⬆️ 0.12-stable "budget"
27c3f8c 
- OpenSourcePolitics/decidim#342
- OpenSourcePolitics/decidim#341
- OpenSourcePolitics/decidim#330
@lu-hamani lu-hamani removed this from the BP enhancements milestone Feb 1, 2019
@lu-hamani lu-hamani mentioned this pull request Apr 9, 2019
Closed
23 tasks
@lu-hamani lu-hamani mentioned this pull request Apr 29, 2019
Closed
3 tasks
@paulinebessoles paulinebessoles deleted the 0.12-stable-budget-with-tests branch October 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moustachu moustachu moustachu approved these changes

+1 more reviewer

@lu-hamani lu-hamani lu-hamani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@armandfardeau armandfardeau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@armandfardeau @moustachu @lu-hamani @juliesimon