Fix/surveys sortable questions non mandatory #314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
lu-hamani
approved these changes
Oct 17, 2018
lu-hamani
left a comment
lu-hamani
left a comment
There was a problem hiding this comment.
Works fine. Good to go if checks pass
lu-hamani
suggested changes
Oct 17, 2018
lu-hamani
left a comment
lu-hamani
left a comment
There was a problem hiding this comment.
Before merging translation is needed as shown in the following screenshots. First word of each error messages is in english
lu-hamani
suggested changes
Oct 17, 2018
lu-hamani
approved these changes
Oct 17, 2018
armandfardeau
deleted the
Fix/surveys-sortable-questions-non-mandatory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Fix validation issue on survey sortable question
The previous method did not validate correctly, all questions to be sorted were treated as mandatory questions
This PR solves this problem :
When question is mandatory -> question answers are validated
When question is not mandatory but one the question answers is checked -> question answers are validated
When question is not mandatory and no question answer is checked -> question answers are not validated and empty response is alllowed
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)