Skip to content

Proposals caps first #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moustachu merged 9 commits into from
Sep 21, 2018
Merged

Proposals caps first #259

moustachu merged 9 commits into from
Sep 21, 2018

Conversation

@armandfardeau
Copy link
Collaborator

@armandfardeau armandfardeau commented Sep 13, 2018 •
edited
Loading

🎩 What? Why?

Capitalize title and body for the user is more friendly and avoid the frustration of getting your proposals rejected for a typo, or because you don't know it was mandatory.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

image

@ghost ghost assigned armandfardeau Sep 13, 2018
@ghost ghost added the needs-review label Sep 13, 2018
juliesimon
juliesimon previously approved these changes Sep 14, 2018
View reviewed changes
@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 14, 2018 •
edited
Loading

@moustachu Decidim-proposals tests seem broken, do you know how to make proper concerns?

@moustachu
Copy link
Member

moustachu commented Sep 16, 2018

@armandfardeau merge to master ??

@armandfardeau armandfardeau changed the base branch from master to 0.12-stable September 17, 2018 08:17
@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 17, 2018

@armandfardeau merge to master ??

-> Fixed

@armandfardeau armandfardeau added the WIP Work in Progress label Sep 17, 2018
@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 17, 2018 •
edited
Loading

@moustachu I just re-run tests :

Failure/Error:
  describe ProposalForm do
    it_behaves_like "a proposal form"
  end

LoadError:
  Unable to autoload constant Decidim::Proposals::Admin::ProposalForm, expected /Users/armandfardeau/WWW/osp-decidim/decidim-proposals/app/forms/decidim/proposals/admin/proposal_form.rb to define it

@armandfardeau armandfardeau removed the WIP Work in Progress label Sep 19, 2018
moustachu
moustachu approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@moustachu moustachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit 👍

@moustachu moustachu merged commit a5e394e into 0.12-stable Sep 21, 2018
@ghost ghost removed the needs-review label Sep 21, 2018
@armandfardeau armandfardeau mentioned this pull request Dec 3, 2018
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moustachu moustachu moustachu approved these changes

+1 more reviewer

@juliesimon juliesimon juliesimon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@armandfardeau armandfardeau

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@armandfardeau @moustachu @juliesimon