Skip to content

Conversation

@armandfardeau
Copy link
Collaborator

@armandfardeau armandfardeau commented Aug 28, 2018

🎩 What? Why?

Debates are now reportable when unofficial.

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

2018-08-28 15 56 09
2018-08-28 15 56 28
image

@armandfardeau armandfardeau added the WIP Work in Progress label Aug 28, 2018
@armandfardeau armandfardeau self-assigned this Aug 29, 2018
@armandfardeau
Copy link
Collaborator Author

@moustachu May you have a look on my code ? I'm adding some tests currently.

@juliesimon
Copy link

juliesimon commented Sep 3, 2018

Tested locally, everthing works fine !

Only problem is, when a debate is reported and then hidden, it still appears in the stats on the participatory process' show.

Here I have 3 debates because I moderated one:
capture d ecran 2018-09-03 a 12 10 29

But on the stats it says there are 4 debates:
capture d ecran 2018-09-03 a 12 10 41

Did not count how many debates there were in total in my seeded platform, but I'm pretty sure there should be the same problem on the homepage stats section:
capture d ecran 2018-09-03 a 12 12 36

@armandfardeau could you please make sure only the debates that are not hidden are showed in the stats ?

@armandfardeau
Copy link
Collaborator Author

@juliesimon Is that the same with processes? If not, I'm sure will do it.

@moustachu
Copy link
Member

@armandfardeau Code seems OK to me

I do agree with @juliesimon : moderated debates should be left off the statistics.
If it's not the case for proposals, then we should raise a bug on the master branch.

@ghost ghost added the needs-review label Sep 4, 2018
@armandfardeau
Copy link
Collaborator Author

@moustachu @juliesimon This can be reviewed and shipped. We both agreed to treat stats issue aside.

Copy link

@juliesimon juliesimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything's ok from a functional point of view !

@moustachu moustachu merged commit 99966ed into 0.12-stable Sep 5, 2018
@ghost ghost removed the needs-review label Sep 5, 2018
Copy link
Member

@moustachu moustachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paulinebessoles paulinebessoles deleted the reportable-debate branch October 6, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

WIP Work in Progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants