-
Notifications
You must be signed in to change notification settings - Fork 5
Allow debates to be reported #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@moustachu May you have a look on my code ? I'm adding some tests currently. |
|
Tested locally, everthing works fine ! Only problem is, when a debate is reported and then hidden, it still appears in the stats on the participatory process' show. Here I have 3 debates because I moderated one: But on the stats it says there are 4 debates: Did not count how many debates there were in total in my seeded platform, but I'm pretty sure there should be the same problem on the homepage stats section: @armandfardeau could you please make sure only the debates that are not hidden are showed in the stats ? |
|
@juliesimon Is that the same with processes? If not, I'm sure will do it. |
|
@armandfardeau Code seems OK to me I do agree with @juliesimon : moderated debates should be left off the statistics. |
|
@moustachu @juliesimon This can be reviewed and shipped. We both agreed to treat stats issue aside. |
juliesimon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything's ok from a functional point of view !
moustachu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍



🎩 What? Why?
Debates are now reportable when unofficial.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)