Skip to content

Processes search #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moustachu merged 7 commits into from
Oct 29, 2018
Merged

Processes search #189

moustachu merged 7 commits into from
Oct 29, 2018

Conversation

@armandfardeau
Copy link
Collaborator

@armandfardeau armandfardeau commented Aug 17, 2018 •
edited
Loading

🎩 What? Why?

Ability to order processes in the back-office

📌 Related Issues

📋 Subtasks

  • Add CHANGELOG entry
  • Add tests

📷 Screenshots (optional)

2018-08-17 16 43 56

GIF WEEEE

@ghost ghost assigned armandfardeau Aug 17, 2018
@ghost ghost added the needs-review label Aug 17, 2018
@armandfardeau armandfardeau added the WIP Work in Progress label Aug 17, 2018
@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 3, 2018

@moustachu Could you give me a hint how to to refactor this to ensure a better future compatibility?

@moustachu
Copy link
Member

moustachu commented Sep 3, 2018

@armandfardeau not sure if I have a useful hint on that subject.
But if you copied / adapted the proposals search (admin) for the processes, it should be fine.

⚠️ Just make sure that the "private space" are managed correctly (meaning >> hidden for admin user that ara not listed for a private process)

@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 3, 2018

I will add that condition to tests.

@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 5, 2018

@moustachu This should be done tomorrow morning as i found an unelegant but working way to test !

@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Sep 6, 2018

@moustachu 100% tested ! I noticed that Proposals sorting is not test on admin side, should I add some tests? (Should be quick, it just a duplicate of theses ones)

@armandfardeau armandfardeau removed the WIP Work in Progress label Oct 1, 2018
lu-hamani
lu-hamani previously approved these changes Oct 8, 2018
View reviewed changes
Copy link

@lu-hamani lu-hamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. I wonder if the hover is self-explanatory so as to sort the processes though.

@lu-hamani lu-hamani removed the request for review from valentinchaput October 15, 2018 10:02
@ghost ghost assigned lu-hamani Oct 26, 2018
moustachu
moustachu approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@moustachu moustachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK

@moustachu To be deployed on steamroll

@moustachu moustachu merged commit d752bbd into 0.12-stable Oct 29, 2018
@ghost ghost removed the needs-review label Oct 29, 2018
moustachu added a commit to OpenSourcePolitics/osp-app that referenced this pull request Oct 29, 2018
@moustachu
⬆️ bump 0.12-stable
e809b44 
- OpenSourcePolitics/decidim#305
- OpenSourcePolitics/decidim#325
- OpenSourcePolitics/decidim#280
- OpenSourcePolitics/decidim#189
- OpenSourcePolitics/decidim#310
@paulinebessoles paulinebessoles deleted the processes-search branch October 6, 2021 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moustachu moustachu moustachu approved these changes

+1 more reviewer

@lu-hamani lu-hamani lu-hamani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@armandfardeau armandfardeau

@lu-hamani lu-hamani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@armandfardeau @moustachu @lu-hamani