Skip to content

Conversation

@armandfardeau
Copy link
Collaborator

🎩 What? Why?

Fix progress meter when over 100%

📌 Related Issues

📷 Screenshots (optional)

image

👻 GIF

@ghost ghost assigned armandfardeau Jul 26, 2018
@ghost ghost added the needs-review label Jul 26, 2018
@armandfardeau armandfardeau requested a review from juliesimon July 26, 2018 13:16
@armandfardeau armandfardeau changed the title 🐛💄 Fix progress meter when over 100% Fix progress meter when over 100% Jul 26, 2018
@juliesimon
Copy link

@armandfardeau test fonctionnel ok

@armandfardeau
Copy link
Collaborator Author

armandfardeau commented Aug 2, 2018

Wonderfull !

Copy link

@juliesimon juliesimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold - We should wait to see why we can indicate more than 100%

@armandfardeau
Copy link
Collaborator Author

@juliesimon @moustachu As my PR is going to be merge in Decidim/Decidim, I suggest that we closed this one and will redo a PR with the appropriate correction.

@armandfardeau armandfardeau added WIP Work in Progress ice and removed WIP Work in Progress needs-review labels Aug 3, 2018
@ghost ghost removed the ice label Aug 3, 2018
@armandfardeau armandfardeau deleted the 0.12-stable-fix-progress-bar branch August 3, 2018 08:34
@juliesimon
Copy link

Woooohooooo 1st OSP's PR to Decidim 🍾 🎉
Well done @armandfardeau !

@virgile-dev
Copy link

Well done !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants