[DO NOT MERGE] - Convert nyx branch to C (nyx-c) #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Deleted multiple unused files including Button.cpp, Colorset.cpp, Colortypes.cpp, Helios.cpp, and others to streamline the codebase. - Updated header files to reflect changes in structure and naming conventions, transitioning from class-based to struct-based definitions for better clarity. - Modified the Makefile to accommodate changes in source file extensions and compilation settings, ensuring compatibility with the new structure. - Added new entries to .gitignore to exclude unnecessary file types. These changes enhance maintainability and clarity while adhering to the KISS principle.
- Replaced all instances of Time_getCurtime(), Time_init(), and related functions with their lowercase counterparts (time_get_current_time(), time_init(), etc.) for consistency and improved readability. - Updated function calls across multiple files including Button.c, Helios.c, Led.c, Pattern.c, TimeControl.c, and Timer.c to reflect the new naming conventions. - These changes enhance code clarity and maintainability while adhering to the KISS principle.
livingkurt
changed the title
livingkurt
changed the title
…e on button press in sleep mode
…pattern functionality - Introduced Button.cpp for managing button states and interactions, including support for CLI and embedded environments. - Added Colorset.cpp and Colortypes.cpp to handle color management, including HSV and RGB conversions. - Implemented Pattern.cpp and Patterns.cpp for defining and managing light patterns, enhancing visual effects. - Updated Makefile to include new source files and ensure proper compilation across different environments. - Refactored existing code to improve structure and maintainability, adhering to the KISS principle.
- Removed C++ specific variables and flags, switching to C compiler settings for consistency. - Consolidated source file definitions and updated object and dependency file generation to streamline the build process. - Enhanced compatibility across different operating systems by standardizing source file search patterns.
- Removed exclusion for .c files and added support for .test and .conf files. - Included .github/workflows/** to ensure workflow files are tracked. - These changes enhance the management of ignored files, improving build and development processes.
- Changed the compiler from gcc to g++ to support C++ code. - Updated CFLAGS to use the C++11 standard. - Adjusted the linking process to include the C++ standard library. - These changes enhance compatibility for C++ source files and improve the build process.
- Removed the C++ standard library from the linking process. - Adjusted the helios target to link only with local libraries, improving build accuracy. - These changes streamline the compilation process and enhance compatibility with the current project structure.
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
…lti-line comments
…tency - Converted remaining C-style comments to C++ style comments. - Updated comments to provide clearer descriptions of functionality and intent. - Enhanced readability and maintainability of the codebase.
- Updated comments to provide clearer descriptions of color selection behavior. - Converted C-style comments to C++ style for improved readability. - These changes contribute to better understanding and maintainability of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.