nyx #132
Open
nyx #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new macro NUM_COLOR_GROUPS to define the number of color groups in the color selection menu. - Updated the color_menu_data array to use NUM_COLOR_GROUPS for better maintainability. - Removed the autoplay feature handling code to simplify the state management in handle_state_modes. - Adjusted color selection logic in handle_state_color_group_selection to reflect the new group count. These changes enhance the clarity and flexibility of the color selection system while adhering to the KISS principle.
- Deleted aeos_build.yml and aeos_release.yml workflows as they are no longer needed. - This cleanup helps streamline the CI/CD process and reduces maintenance overhead. These changes maintain the project's focus on simplicity and efficiency.
- Increased the number of color slots from 1 to 3 in HeliosConfig.h to allow for more color selections. - Reduced the number of mode slots from 3 to 1 to simplify mode management. - Updated multiple test files to reflect changes in color handling, including adjustments to color values and removal of obsolete tests. - Deleted several outdated test files related to color selection and pattern testing to streamline the test suite. These changes improve the flexibility of color management while maintaining simplicity in the configuration and testing processes.
- Removed several obsolete pattern cases from Patterns.cpp to streamline the pattern management. - Updated the PatternID enum in Patterns.h to reflect the removal of unused patterns, ensuring a cleaner and more maintainable codebase. - Adjusted the default pattern arguments for existing patterns to improve functionality. These changes simplify the pattern handling while adhering to the KISS principle, enhancing overall code clarity and maintainability.
- Replaced the PATTERN_FLARE case with PATTERN_RAZOR in Patterns.cpp, adjusting the on_dur, off_dur, and gap_dur values for improved functionality. - Updated the PatternID enum in Patterns.h to reflect the change from PATTERN_FLARE to PATTERN_RAZOR, ensuring consistency in pattern definitions. These changes enhance the pattern management while adhering to the KISS principle, maintaining clarity and simplicity in the codebase.
- Replaced color values in multiple test files to ensure consistency and accuracy in color selection scenarios. - Adjusted the test inputs and expected outputs to reflect the new color handling logic. - Enhanced the clarity of test cases by maintaining a uniform color representation across all tests. These changes improve the reliability of the test suite while adhering to the KISS principle, ensuring straightforward and maintainable test cases.
- Deleted the autoplay toggle case from handle_state_modes and the corresponding flag from the FLAG enum in Helios.h to simplify state management. - This change streamlines the codebase by eliminating unnecessary complexity while adhering to the KISS principle. These modifications enhance the clarity and maintainability of the Helios application.
- Eliminated the conjure mode state and related flag from Helios, simplifying the state management logic. - Adjusted the global flags loading process to directly read the current mode without conjure mode checks. - Removed obsolete test cases related to conjure mode to streamline the test suite. These changes enhance the clarity and maintainability of the Helios application while adhering to the KISS principle.
- Eliminated the conjure flag from the EEPROM dump output in cli_main.cpp to simplify the displayed information. - Adjusted the printf statement to reflect the removal of the conjure flag, enhancing clarity in the output. These changes streamline the CLI output while adhering to the KISS principle, improving overall maintainability and readability of the codebase.
- Deleted the aeos_build.yml and aeos_release.yml files to streamline the CI/CD process. - This change simplifies the workflow management and focuses on essential build and release processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.