Daniel/aeos/fade attempt 2 #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng. Updated related variables and methods to reflect the change from morphing to fading duration. Adjusted Makefile to reference aeos_firmware instead of helios_firmware for consistency.
…" for consistency. Adjusted related methods and variables in Pattern class to reflect this change, ensuring clarity in functionality. Updated comments and documentation accordingly.
…instead of 1, ensuring correct behavior for fade duration patterns.
…tion within Pattern class for improved clarity and consistency.
…s. Updated on and off duration handling to ensure correct timing during fading patterns, while removing redundant calculations. Adjusted default pattern parameters for improved behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.