Partial fixed_params into functions upon model creation. Stateless treatment of dynamic IrregSpacedGrids, in particular ShockGrids.
#235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eatment of dynamic IrregSpacedGrids, in particular ShockGrids.
Three bugs in _partial_fixed_params_into_regimes: 1. internal_functions.regime_transition_probs was not updated alongside the top-level attribute, causing simulation to use un-partialled functions for regime transitions. 2. regime_transition_probs was partialled with ALL regime fixed params, but it only accepts a subset — breaking inspect.signature used by dags.concatenate_functions in to_dataframe. 3. to_dataframe additional_targets built DAGs from raw functions that still expected fixed params no longer present in runtime params. Fixes: update internal_functions, filter kwargs per function signature, store resolved_fixed_params on InternalRegime for target computation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.